This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Added transliterator to email and username #333
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #311
I've added transliteration to email and username.
I've added some tests that will make sure that every email and username from any provider are valid.
I've updated readme.md file to inform of the new intl and php dependency.
Should we be worried about those people that need transliteration (of any kind) but still use a lower PHP version?
For these people Faker will not work after the update as I've removed all "toAscii" methods.